Skip to content

Fix static attention non-HF RoPE implementation #11808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Fix static attention non-HF RoPE implementation #11808

merged 1 commit into from
Jun 20, 2025

Conversation

@sxu
Copy link
Contributor

@sxu sxu commented Jun 19, 2025 •
edited
Loading

  • Fix non-HF style RoPE.
  • Support QK norm after RoPE.
  • Update tests to initialize QK norm weights for better coverage.

Differential Revision: D76951243

@sxu sxu requested review from jackzhxng and lucylq as code owners June 19, 2025 02:15
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11808

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 992803c with merge base a1dec07 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 19, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 19, 2025

This pull request was exported from Phabricator. Differential Revision: D76951243

@github-actions
Copy link

github-actions bot commented Jun 19, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@sxu sxu requested review from YIWENX14 and billmguo June 19, 2025 02:18
@sxu sxu changed the title Fix static attention RoPE implementation Fix static attention non-HF RoPE implementation Jun 19, 2025
sxu added a commit to sxu/executorch that referenced this pull request Jun 19, 2025
@sxu @facebook-github-bot
Fix static attention RoPE implementation (pytorch#11808)
d49370b 
Summary:

- Fix non-HF style RoPE.
- Support QK norm after RoPE.

Differential Revision: D76951243
@sxu sxu force-pushed the export-D76951243 branch from 10ad5df to d49370b Compare June 19, 2025 03:06
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 19, 2025

This pull request was exported from Phabricator. Differential Revision: D76951243

sxu added a commit to sxu/executorch that referenced this pull request Jun 19, 2025
@sxu @facebook-github-bot
Fix static attention RoPE implementation (pytorch#11808)
2c92e9b 
Summary:

- Fix non-HF style RoPE.
- Support QK norm after RoPE.

Differential Revision: D76951243
@sxu sxu force-pushed the export-D76951243 branch from d49370b to 2c92e9b Compare June 19, 2025 03:12
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 19, 2025

This pull request was exported from Phabricator. Differential Revision: D76951243

@sxu @facebook-github-bot
Fix static attention RoPE implementation (pytorch#11808)
992803c 
Summary:

- Fix non-HF style RoPE.
- Support QK norm after RoPE.
- Update tests to initialize QK norm weights for better coverage.

Reviewed By: billmguo

Differential Revision: D76951243
@sxu sxu force-pushed the export-D76951243 branch from 2c92e9b to 992803c Compare June 19, 2025 04:16
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 19, 2025

This pull request was exported from Phabricator. Differential Revision: D76951243

@facebook-github-bot facebook-github-bot merged commit 5c91435 into pytorch:main Jun 20, 2025
102 of 104 checks passed
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
@sxu @hinriksnaer
Fix static attention non-HF RoPE implementation
300de0e 
Differential Revision: D76951243

Pull Request resolved: pytorch#11808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billmguo billmguo billmguo approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@YIWENX14 YIWENX14 Awaiting requested review from YIWENX14

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sxu @facebook-github-bot @billmguo